Remove unused items in ArchMiscWindows - #8392
Merged
Merged
Conversation
sithlord48
changed the title
ArchMiscWindows
sithlord48
changed the title
ArchMiscWindows
sithlord48
force-pushed
the
cleanupArchMiscWindows
branch
from
March 24, 2025 11:58
d0c210e to
1d502b5
Compare
nbolton
approved these changes
Mar 24, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Can't test on Windows right now but should be find if CI can build.
nbolton
enabled auto-merge (rebase)
March 24, 2025 12:05
sithlord48
force-pushed
the
cleanupArchMiscWindows
branch
from
March 24, 2025 12:07
1d502b5 to
41a1300
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a bunch of unused methods from
ArchMiscWindowsArchMiscWindows::hasValueArchMiscWindows::setIconsArchMiscWindows::getIconsArchMiscWindows::deleteValueArchMiscWindows::deleteKeyTreeArchMiscWindows::setValueBinaryArchMiscWindows::readValueBinaryArchMiscWindows::addDialogArchMiscWindows::removeDialogArchMiscWindows::s_dialogArchMiscWindows::cleanupArchMiscWindows::processDialog