Remove ArchFile - #8389
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sithlord48
force-pushed
the
rmArchFile
branch
2 times, most recently
from
March 24, 2025 12:07
2210456 to
abb3e29
Compare
nbolton
reviewed
Mar 24, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Looks good but I want to test on Windows before approving. Hopefully, I can do this later today or tomorrow morning when I'm back in the office.
nbolton
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Step closer to being rid of
ARCHThis removes theARCH_FILEclasslib/arch/multibyte.hARCH->getBaseFilenamewithQFileInfo::fileName()ARCH->getInstalledDirectorytoMSWindowsWatchdogARCH_FILElib/arch/IArchFile.hlib/arch/unix/ArchFileUnix.[cpp|h]lib/arch/win32/ArchFileWindows.[cpp|h]