Remove the Common/Std*.h and platform/Win32Hook.h files - #8385
Merged
Conversation
sithlord48
force-pushed
the
reUnused_again
branch
from
March 20, 2025 14:45
2e4803e to
3cafe6f
Compare
sithlord48
changed the title
sithlord48
changed the title
nbolton
previously approved these changes
Mar 21, 2025
nbolton
left a comment
nbolton
left a comment
Member
There was a problem hiding this comment.
Looks good, could land as is but there is some dead code that can go.
remove _NOEXCEPT define and just use throw()
sithlord48
force-pushed
the
reUnused_again
branch
from
March 21, 2025 11:33
0491037 to
be1b669
Compare
nbolton
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to
lib/commonStd*.hfiles and uses the types directly_NOEXCEPTdefine and usethrow()MacOSXPrecomp.hChanges to
lib/platformWin32Hook.hparts toMSWindowsHook.hChanges to
apps/deskflow-guiQUtilityProcessorArch.h