fix: Use correct casing for RemoteHost value in Settings.h - #8375
Merged
Conversation
Member
|
There is no convention that is the point of using the struct keys to read / write to make sure you don't type it different |
sithlord48
force-pushed
the
remote-host-typo
branch
from
March 17, 2025 16:46
7821b9c to
0ccf522
Compare
nbolton
marked this pull request as ready for review
March 17, 2025 16:53
Member
Author
Thanks, if you're happy then go ahead and land. |
nbolton
force-pushed
the
remote-host-typo
branch
from
March 17, 2025 17:00
0ccf522 to
98e17e7
Compare
sithlord48
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes typos in settings keys cases
checkpeerfingerprints=>checkPeerFingerprintsinvertscrolldirection=>invertScrollDirectionremotehost=>remoteHostDraft: Ah, spotted 2 more:
checkpeerfingerprintsinvertscolldirection