Skip to content

refactor: mainwindow move save config to a button - #8360

Merged
nbolton merged 2 commits into
masterfrom
saveServerSettings
Mar 17, 2025
Merged

refactor: mainwindow move save config to a button#8360
nbolton merged 2 commits into
masterfrom
saveServerSettings

Conversation

@sithlord48

@sithlord48 sithlord48 commented Mar 14, 2025

Copy link
Copy Markdown
Member
  • Remove from the main window the "save Configuration as" menu item and replace it with a button that is only shown when in server mode.
  • Add "configure" icon to the "Configure Server" button

@sithlord48
sithlord48 requested a review from nbolton March 14, 2025 16:05
@nbolton
nbolton force-pushed the saveServerSettings branch from af3f3ce to 896805c Compare March 17, 2025 11:08
@nbolton

nbolton commented Mar 17, 2025

Copy link
Copy Markdown
Member

While testing, I found another problem with #8372:
Image

I'll also post there since I think it's not caused by this PR.

@nbolton

nbolton commented Mar 17, 2025

Copy link
Copy Markdown
Member

Interesting, when I click the save icon it also causes bug #8372:

image

@nbolton

nbolton commented Mar 17, 2025

Copy link
Copy Markdown
Member

Still getting a not-so-transient Flatpak error:

fatal: unable to access 'https://gitlab.freedesktop.org/libinput/libei/': The requested URL returned error: 503
Failed to download sources: module libei: Child process exited with code 128

@nbolton
nbolton merged commit d537a23 into master Mar 17, 2025
@nbolton
nbolton deleted the saveServerSettings branch March 17, 2025 11:18
@sithlord48 sithlord48 mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants