feat: Check MSVC redist version in WiX installer - #8342
Merged
Conversation
12 tasks
nbolton
force-pushed
the
msi-redist-version
branch
from
March 11, 2025 14:59
eb9893a to
afa3a1a
Compare
sithlord48
reviewed
Mar 11, 2025
nbolton
force-pushed
the
msi-redist-version
branch
4 times, most recently
from
March 11, 2025 16:59
6236e59 to
1b42485
Compare
sithlord48
requested changes
Mar 11, 2025
nbolton
commented
Mar 11, 2025
nbolton
force-pushed
the
msi-redist-version
branch
3 times, most recently
from
March 11, 2025 20:38
ade83de to
a3bad13
Compare
sithlord48
requested changes
Mar 11, 2025
Member
|
Did a quick test on a vm and the configuration step seams to have picked up the proper vc installed. |
12 tasks
Member
Author
Cool. Yeah it's a real faff to test. Edit: You can use DebugView to see what's going on with the WiX/MSI DLL in the background. In case you didn't know. |
nbolton
force-pushed
the
msi-redist-version
branch
4 times, most recently
from
March 12, 2025 11:20
3c72d1b to
c54b7e5
Compare
nbolton
force-pushed
the
msi-redist-version
branch
from
March 12, 2025 11:40
c54b7e5 to
5562a69
Compare
nbolton
force-pushed
the
msi-redist-version
branch
from
March 12, 2025 11:43
5562a69 to
5545f67
Compare
sithlord48
self-requested a review
March 12, 2025 11:46
sithlord48
enabled auto-merge (rebase)
March 12, 2025 11:51
sithlord48
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #8331
This will help to rule out any issues with older runtimes by preventing installs where the latest runtime isn't installed.
To do this, I had to make a custom DLL and call it from the MSI. Tested by manually changing the 'Minor' value on the MSVC registry key.
Todo:
Before="InstallInitialize"works as expected (wasBefore="InstallServices")Error message:
