fix: Guard MSVC runtime version depending on compiler version - #8312
Merged
Conversation
nbolton
force-pushed
the
fix8311
branch
4 times, most recently
from
March 6, 2025 14:38
a287ec8 to
2c2f7d8
Compare
Member
|
Should the gui do this check as well ? |
Member
Author
We could if we link the That said, the user should never be able to get to the point of running the GUI because this new feature prevents the MSI from completing the installation. |
nbolton
marked this pull request as ready for review
March 6, 2025 15:33
sithlord48
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8311
PR shows an error dialog and exits the program (server, client, and daemon) if the MSVC++ runtime is too old. This avoids silent crashes which are very confusing and waste a lot of time. Windows doesn't tell you when a binary was linked against an older library, it just loads whatever DLL it finds and hopes for the best.
Wrong version:
Missing runtime (default Windows message):
