Refactor Windows daemon to use Qt args and improve logging - #8300
Merged
Conversation
nbolton
changed the title
nbolton
force-pushed
the
refactor-daemon-qt
branch
5 times, most recently
from
March 11, 2025 21:41
00dd5d2 to
31678ba
Compare
nbolton
force-pushed
the
refactor-daemon-qt
branch
10 times, most recently
from
March 14, 2025 12:12
08de4a7 to
336ee09
Compare
nbolton
changed the title
nbolton
force-pushed
the
refactor-daemon-qt
branch
11 times, most recently
from
March 14, 2025 13:42
d4a49a2 to
8860729
Compare
nbolton
force-pushed
the
refactor-daemon-qt
branch
3 times, most recently
from
March 14, 2025 13:54
66e4fa3 to
241f332
Compare
nbolton
marked this pull request as ready for review
March 14, 2025 13:57
nbolton
enabled auto-merge (rebase)
March 14, 2025 13:57
- Make `clearSettings` const in daemon app - Improve readability of empty command check
This also improves some logging and adds discreet try-catch blocks for each function call which improves diagnostics
nbolton
force-pushed
the
refactor-daemon-qt
branch
from
March 14, 2025 14:10
241f332 to
ad9a8ff
Compare
sithlord48
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8349
Related: #8288
Blockers:
Todo: