Skip to content

Remove Inverse Connection - #8240

Merged
nbolton merged 3 commits into
masterfrom
rmInvConnection
Feb 25, 2025
Merged

Remove Inverse Connection#8240
nbolton merged 3 commits into
masterfrom
rmInvConnection

Conversation

@sithlord48

@sithlord48 sithlord48 commented Feb 22, 2025

Copy link
Copy Markdown
Member
  • Remove the unmaintained Inverse Connections option.
  • Simplify the MainWindow mode selection

@sithlord48
sithlord48 requested a review from nbolton February 22, 2025 06:08
@sithlord48
sithlord48 force-pushed the rmInvConnection branch 4 times, most recently from b69f615 to be64ee2 Compare February 25, 2025 13:23

@nbolton nbolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor readability change suggestion, but up to you.
Tested and working on macOS and Linux.
My Windows box is out of action at the moment (because... vcpkg).
I will test on Windows once it's working again.

Comment thread src/apps/deskflow-gui/MainWindow.cpp Outdated
Comment thread src/apps/deskflow-gui/MainWindow.cpp Outdated
@sithlord48
sithlord48 force-pushed the rmInvConnection branch 2 times, most recently from 15620de to 200a531 Compare February 25, 2025 14:05
@nbolton
nbolton enabled auto-merge (rebase) February 25, 2025 14:16
@nbolton
nbolton self-requested a review February 25, 2025 14:16
@nbolton

nbolton commented Feb 25, 2025

Copy link
Copy Markdown
Member

Oops, still need to test on Windows.

Edit: Ah, interesting. TIL, re-requesting a review doesn't un-approve. Tested and working on Windows.

@nbolton
nbolton merged commit 5b54849 into master Feb 25, 2025
@nbolton
nbolton deleted the rmInvConnection branch February 25, 2025 14:18
sithlord48 added a commit that referenced this pull request Apr 20, 2025
sithlord48 added a commit that referenced this pull request Apr 21, 2025
nbolton pushed a commit that referenced this pull request Apr 21, 2025
nbolton pushed a commit that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants