feat: Handle empty update response and improve logging - #8100
Conversation
nbolton
commented
Jan 16, 2025
nbolton
commented
- Shows warning when empty response back from update server.
- Improved logging for when new version available/not available.
nbolton
changed the title
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Don't put the strings in the () for qDebug() , qWarning, and qInfo() . Also this can be done better by using one string perhaps
auto string = QStringLiteral("current version %1").arg (kversion)
if outof date
string.append(QStringLiterla("is out of date") ...
etc.. before printing to the console.
|
Thanks for the review, I'll set to draft until I can carve out some time to fix. |
|
Is this still being worked on our should be close it ? |
|
Needs finishing. Not very urgent but I will complete. |
7646192 to
f5bfc1a
Compare
f5bfc1a to
0f46e1d
Compare
sithlord48
left a comment
sithlord48
left a comment
There was a problem hiding this comment.
Do we really need to log its out of date the gui will show this via the icon.
0f46e1d to
11f8e76
Compare
Think about this from a troubleshooting perspective. When a user sends us information, they often send us either a screenshot or a log but rarely both. If we receive only the log, having all the info there saves time for everyone. Logs aren't just for the user, they're also for people helping the user. |
11f8e76 to
da9a2d9
Compare
|
@sithlord48 Ready for your review. It would be nice to get this merged, as it has been open since Jan. |
2 participants
