fix: Parse only the patch number from version check result - #8086
Merged
Conversation
nbolton
force-pushed
the
version-check-patch-number
branch
from
March 14, 2025 14:39
dc389d9 to
bdfeb98
Compare
nbolton
marked this pull request as ready for review
March 14, 2025 14:40
nbolton
enabled auto-merge (rebase)
March 14, 2025 14:41
sithlord48
approved these changes
Mar 14, 2025
sithlord48
left a comment
sithlord48
left a comment
Member
There was a problem hiding this comment.
ok with me if you have tested it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the split was being done on the wrong part of the version checker result meaning it would sometimes result in 0 rather than the actual patch number.