Merged
Conversation
procfs FDTarget::Other type doesn't handle non-inode fds like onload:[udp:2:2024], In eminence/procfs#356 they added a new FDTarget::Unknown type to address this. In procfd, I'm treating both as Other since they are represented as strings, and the differentiation between Other and Unknown would be confusing.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of unknown file descriptor types by upgrading the procfs dependency and adapting to new FDTarget types. The change improves representation of non-inode file descriptors that were previously displayed as generic "other" entries.
- Updates procfs dependency from 0.17.0 to 0.18.0
- Handles the new
FDTarget::Unknowntype introduced in procfs - Improves display format for
OtherandUnknownfd types to show actual data instead of generic "other"
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updates procfs dependency to version 0.18.0 |
| src/main.rs | Adds handling for new Unknown FDTarget type and improves display formatting for Other/Unknown types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mkomitee
approved these changes
Sep 12, 2025
mkomitee
left a comment
mkomitee
left a comment
There was a problem hiding this comment.
I think it may be time to consider creating some (more) tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
procfs FDTarget::Other type doesn't handle non-inode fds like onload:[udp:2:2024],
In eminence/procfs#356 they added a new FDTarget::Unknown type to address this.
In procfd, I'm treating both as Other since they are represented as
strings, and the differentiation between Other and Unknown would be
confusing.