Repository navigation
fix(pod): show SchedulingGated for pods held by scheduling gates - #4313
Merged
uozalp merged 3 commits intoOct 22, 2026
Merged
Conversation
uozalp
reviewed
Oct 19, 2026
Comment on lines
+474
to
+476
| if c.Type == v1.PodScheduled && c.Reason == v1.PodReasonSchedulingGated { | ||
| status = v1.PodReasonSchedulingGated | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit: Consider adding a break after setting the status, since we've found the condition we're looking for and don't need to continue iterating.
Contributor
Author
There was a problem hiding this comment.
Good point, added the break in c6e8399. go test ./internal/render/ still passes.
uozalp
requested changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A pod held back by
spec.schedulingGatesshowsPendingin the k9s pod view. kubectl, and k9s's ownPodStatushelper, showSchedulingGated. That's the only hint that the pod is waiting on a gate rather than on the scheduler. kubectl'sprintPoddoes:Pod.Phase, which renders the STATUS column, skipped this check.Fix
Pod.Phasenow applies the samePodScheduled/SchedulingGatedcondition check asPodStatus.Tests
New
TestCheckPhasecasescheduling-gated. It returnedPendingbefore the fix and returnsSchedulingGatednow.go test ./internal/render/... ./internal/view/...passes.AI-assisted: I directed the investigation and reviewed and verified the change myself.