Repository navigation
Conversation
Signed-off-by: YoungjuKim <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
k9s.gpuVendorsis amap[string]stringininternal/config/k9s.go(vendor name -> resource name, e.g.
bozo: bozo/gpu), and that is how theREADME documents it. The JSON schema (
internal/config/json/schemas/k9s.json)requires every value to be an object with
vendorandmodel, so a configthat follows the README fails validation and k9s logs
k9s config file ... load failed, while a config that follows the schema wouldnot unmarshal into the Go type. The mismatch has been there since the setting
was added in v0.50.8.
Changes:
gpuVendorsvalues are strings;testdata/k9s/cool.yaml: add agpuVendorsentry soTestValidateK9s/happycovers it;
(the tabs make the sample invalid YAML when copied), and remove a stale
top-level
k9s.noIconsline (the setting lives underk9s.ui.noIcons, whichthe sample already shows; the top-level key is not in the schema or the
K9sstruct).Testing: I did not run
go test(the module cache here lacks gojsonschema).I checked the README sample and
testdata/k9s/cool.yamlagainst the schemawith a small script implementing the draft-07 keywords the schema uses: with
the old schema
gpuVendors.bozofails with "expected object, got string";with the new schema both files validate.
This PR was written in part with the assistance of generative AI.
This change was drafted with AI assistance and reviewed by me.
🤖 Generated with Claude Code