test(hasAriaValue): reenable skipped test due to firefox crash - #5229
Merged
Conversation
Garbee
approved these changes
Jul 29, 2026
chutchins25
reviewed
Aug 4, 2026
chutchins25
left a comment
chutchins25
left a comment
Contributor
There was a problem hiding this comment.
Nice work — good to see this one clear out. I confirmed the workaround was the only one: zero remaining references to 5139 or 2045887 anywhere in the head, and no other test in test/ carries a Firefox guard for it. Closes #5139 matches what you asked for on the issue, too.
One question inline about the remaining Firefox quirks.
Also worth a rebase before merge — the branch is 22 commits behind develop with a base predating the pnpm conversion (#5264), so the green checks ran on the old npm toolchain. No conflicts, just means the checkmark is a bit stale.
WilcoFiers
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in latest Firefox (153.0) and this looks like it doesn't crash the browser anymore. The other non-crash issues still exist (logging the warning,
nullfor emptyariaLabelledByElements), but we should be able to reenable the test now.Closes: #5139