test: setup the virtual tree using root rather than fixture - #5219
Merged
Conversation
straker
commented
Jul 20, 2026
| createGrid(); | ||
| assert.isDefined(fixture._grid); | ||
| assert.equal(fixture._grid, fixture.children[0]._grid); | ||
| assert.isTrue(fixture._grid === fixture.children[0]._grid); |
Contributor
Author
There was a problem hiding this comment.
When these two aren't equal, the code freezes as it tries to output the stringified DOM nodes which crashes the browser.
WilcoFiers
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests only set up the virtual tree from the
fixturedown. This causes problems in our tests when code walks up the DOM tree (not the virtual tree) and tries to get virtual nodes from the walk. This causes tests to fail when it wouldn't fail in an actual run (as doingaxe.runsetups the virtual tree for the entire page).This updates the testutils functions to set up the virtual tree using the entire DOM to parity an actual run.