chore: fix getAriaValue and hasAriaValue to handle external api internals - #5164
Merged
Conversation
WilcoFiers
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered as part of the conversion of commons/dom. @chutchins25 had pointed out that the
nullonly check would fail if the value was everundefined, but since all browsers supportednullon all ARIA prop values I didn't think it was necessary. Well turns out that when we set the internals to an object for the external api code, the values no longer returnnullwhen missing butundefined. So need to add theundefinedcheck for those cases.Is
choreas we don't need to announce this fix in the changelog as the feature hasn't be released yet