chore: update deprecated and old deps - #5159
Merged
Merged
Conversation
straker
marked this pull request as ready for review
June 10, 2026 21:48
straker
commented
Jun 10, 2026
| @@ -1 +1,2 @@ | |||
| registry=https://registry.npmjs.org No newline at end of file | |||
| registry=https://registry.npmjs.org | |||
| @deque:registry=https://registry.npmjs.org No newline at end of file | |||
Contributor
Author
There was a problem hiding this comment.
Installing made @deque/dot not use the public npm so needed to add this to make sure it didn't happen again.
Member
There was a problem hiding this comment.
Yea, because our user configs all have @deque pointing to the private registry.
Garbee
reviewed
Jun 11, 2026
| # @see https://github.com/dequelabs/axe-core/issues/4428 | ||
| - dependency-name: 'colorjs.io' | ||
| versions: ['>0.4.3'] | ||
| # Still need to support node 18 in our tests |
Member
There was a problem hiding this comment.
So, we are not supporting Node 18 (or potentially earlier) testing? What exactly is the impact here?
Or is older stuff only tested after being compiled which negates the impact of this dep?
Contributor
Author
There was a problem hiding this comment.
The latter. We cache the built files using current node, then restore the built files when we test older node versions so we don't have to build them.
WilcoFiers
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started because
chromedriverwasn't the latest version in the package-lock so every time I switched between the grunt removal branch and any other branch I had to reinstall chromedriver to the latest. It then spiraled to looking at all the npm warnings and updating what made sense.@babel/plugin-proposal-object-rest-spreadwas deprecated as it was merged into the spec and we can now use the actual package@babel/plugin-transform-object-rest-spreadstandard-versionwas deprecated and they recommend usingcommit-and-tag-versionglobwas prevented from updating to v11 as it removed node version <20 and we still test under node 18. But looking at the code now we only use glob when we build, which we already restore a cache version of before we test our code using different node versions. so we should be able to update it nowThe remaining warns can't be fixed at the moment.
[email protected]and[email protected]are both used by latestcommit-and-tag-version. an issue exists about it[email protected]is used by latesthttp-server. an issue exists about it[email protected]is used bynode-notifier, which hasn't been updated in several years. we could move to https://github.com/Aetherinox/node-toasted-notifier which is a fork of it, but I wasn't sure if we wanted to or not. Alternatively we could just drop the package, it's only used 1 time in our build to notify when axe-core build is completed (a nice to have but not necessary).[email protected]is used by latestmocha, but the next major mocha version looks like it updates to the latest glob