test: allow declarative shadow dom - #5158
Merged
Merged
Conversation
WilcoFiers
reviewed
Jun 12, 2026
| fixture.innerHTML = content; | ||
| if (options.shadow) { | ||
| // allow declarative shadow DOM which requires using setUnsafeHTML to parse | ||
| fixture.setHTMLUnsafe(content); |
Contributor
There was a problem hiding this comment.
Huh. I didn't know you could do that!
WilcoFiers
previously requested changes
Jun 12, 2026
WilcoFiers
left a comment
WilcoFiers
left a comment
Contributor
There was a problem hiding this comment.
The checkSetup thing is missing. I think it'd be nice to convert at least a couple tests to use this just to demonstrate it works. I had to do that locally now to learn that.
WilcoFiers
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
queryFixtureto now support declarative shadow DOM, replacing the need forqueryShadowFixtureandcreateNestedShadowDom. I wanted the detection to be conditional so we didn't need to do the expensive calls ofsetHTMLUnsafeand querying for every shadow on every test. So the code only does the expensive operations when it detects a declarative shadow DOM. Alternatively if we don't like the regex we could just have theoptions.shadowbe passed into thequeryFixture, but that would be a bit odd when the 2nd param is the query, but would be fine for the few times we actually use the functions:queryFixture('<div>', '#target', { shadow: true });