Skip to content

fix(locale): ensure all subtags are correctly set - #5112

Merged
WilcoFiers merged 3 commits into
developfrom
no-nb
May 26, 2026
Merged

fix(locale): ensure all subtags are correctly set#5112
WilcoFiers merged 3 commits into
developfrom
no-nb

Conversation

@WilcoFiers

@WilcoFiers WilcoFiers commented May 20, 2026

Copy link
Copy Markdown
Contributor

nb-no should be no-NB, and all the other should use - not _ since that's not a valid language tag.

@WilcoFiers
WilcoFiers requested a review from a team as a code owner May 20, 2026 17:17
Copilot AI review requested due to automatic review settings May 20, 2026 17:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Norwegian Bokmål locale metadata to use a corrected language code in locales/no_NB.json.

Changes:

  • Change the locale "lang" value in locales/no_NB.json from nb-no to no-NB.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread locales/no_NB.json Outdated
@@ -1,5 +1,5 @@
{
"lang": "nb-no",
"lang": "no-NB",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK fine, so those are wrong too than!

Garbee
Garbee previously requested changes May 20, 2026

@Garbee Garbee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot is correctly pointing out the BCP standard mismatch.

@WilcoFiers WilcoFiers changed the title fix(locale): correct Norwegian no-NB lang code fix(locale): ensure all subtags are correctly set May 21, 2026
@WilcoFiers
WilcoFiers requested a review from Garbee May 21, 2026 16:27
@straker

straker commented May 21, 2026

Copy link
Copy Markdown
Contributor

Do we have a standard for how these should be listed? From what I can find of the ISO 639-1 codes, Norwegian Bokmål should be just nb and not have the no suffix. Or are we wanting these to be more of the language subtag like https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry?

@Garbee

Garbee commented May 21, 2026

Copy link
Copy Markdown
Member

Do we have a standard for how these should be listed? From what I can find of the ISO 639-1 codes, Norwegian Bokmål should be just nb and not have the no suffix. Or are we wanting these to be more of the language subtag like https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry?

This is a good point. I'm not seeing any material around the desired format in https://github.com/dequelabs/axe-core/blob/develop/locales/README.md the docs.

I think we should ultimately align to https://www.w3.org/International/articles/language-tags/ guidance, which ends up at showing hyphens are the intended separator

@WilcoFiers

WilcoFiers commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for looking that up. I did this off the top of my head, but Norwegian is more complicated than I remember. It really is nb-NO, but nb alone is correct too. I'm going to go for the simpler form since we don't have other nb variants and definitely never will.

@Garbee Garbee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligning to the industry consensus, LGTM.

@WilcoFiers
WilcoFiers merged commit 13005ed into develop May 26, 2026
23 checks passed
@WilcoFiers
WilcoFiers deleted the no-nb branch May 26, 2026 14:49
WilcoFiers added a commit that referenced this pull request Jun 1, 2026
##
[4.12.0](v4.11.4...v4.12.0)
(2026-06-01)

### Features

- add gather-internals.js external script
([#5099](#5099))
([c61d58b](c61d58b)),
closes [#5080](#5080)
- **aria-allowed/prohibited-attr, aria-required-parent/children:**
partially support element internals role
([#5080](#5080))
([417b48a](417b48a)),
closes [#5039](#5039)
[#4259](#4259)
- **axe.externalAPIs:** add public api for setting elementInternal data
([#5105](#5105))
([63bab8f](63bab8f))
- **core:** expose normalizeRunOptions
([#4998](#4998))
([b8e6a59](b8e6a59))
- expose axe.resetLocale() to restore the default locale
([#5108](#5108))
([c2b5292](c2b5292)),
closes [#5107](#5107)
- **getRules:** include rule enabled state in returned objects
([#5118](#5118))
([75bf772](75bf772)),
closes [#5116](#5116)
- **list,listitem:** support element internals role
([#5119](#5119))
([7d9d696](7d9d696))
- **new-rule:** check that aria-tab have an accessible name
([#5001](#5001))
([0d4e4e7](0d4e4e7)),
closes [#4842](#4842)
- **rules:** deprecate landmark-complementary-is-top-level rules
([#4992](#4992))
([9e09139](9e09139)),
closes [#4950](#4950)
- **utils:** add `getElementInternals` function
([#5077](#5077))
([1c15f82](1c15f82))

### Bug Fixes

- **aria-allowed-attr:** restrict br and wbr elements to aria-hidden
only ([#4974](#4974))
([c6245e7](c6245e7))
- **aria-conditional-attr:** add support for radio
([#5100](#5100))
([8223c98](8223c98))
- **aria-valid-attr-value:** handle multiple aria-errormessage IDs
([#4973](#4973))
([0489e30](0489e30))
- **aria:** prevent getOwnedVirtual from returning duplicate nodes
([#4987](#4987))
([48ca955](48ca955)),
closes [#4840](#4840)
- **commons/text:** exclude natively hidden elements from
aria-labelledby accessible name
([#5076](#5076))
([ea7202c](ea7202c)),
closes [#4704](#4704)
- **DqElement:** avoid calling constructors with cloneNode
([#5013](#5013))
([0281fa1](0281fa1))
- **existing-rule:** aria-busy now shows an error message for a use with
unallowed children
([#5017](#5017))
([2067b87](2067b87))
- **helpUrl:** ensure axe.configure always updates the help URLs
([#5114](#5114))
([c4f60ff](c4f60ff))
- **label-content-name-mismatch:** match visible text with aria-label
and exclude invisible text
([#5096](#5096))
([3a012a1](3a012a1))
- **locale:** ensure all subtags are correctly set
([#5112](#5112))
([13005ed](13005ed))
- **scrollable-region-focusable:** clarify the issue is in safari
([#4995](#4995))
([4ec5211](4ec5211)),
closes
[WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870)
[WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290)
- **scrollable-region-focusable:** do not fail scroll areas when all
content is visible without scrolling
([#4993](#4993))
([838707a](838707a))
- **target-size:** determine offset using clientRects if target is
display:inline
([#5012](#5012))
([a4b8091](a4b8091))
- **target-size:** ignore position: fixed elements that are offscreen
when page is scrolled
([#5066](#5066))
([1229a6e](1229a6e)),
closes [#5065](#5065)
- **target-size:** ignore widgets that are inline with other inline
elements ([#5000](#5000))
([a8dd81b](a8dd81b))
- **utils/getAncestry:** escape node name
([#5079](#5079))
([d1fabaa](d1fabaa)),
closes [#5078](#5078)
- **utils:** Add null check to parseCrossOriginStylesheet, closes
[#5074](#5074)
([#5075](#5075))
([f12ef32](f12ef32))
- **utils:** update isShadowRoot to use spec-compliant custom element
regex ([#5059](#5059))
([edc6ce2](edc6ce2)),
closes [#5030](#5030)

This PR was opened by a robot 🤖 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants