chore(utils/is-valid-custom-element-name): helper function to determine if custom-element nodeName is valid - #5097
Merged
Merged
Conversation
…node could be a custom element
straker
changed the title
straker
changed the title
WilcoFiers
approved these changes
May 7, 2026
bwyard
added a commit
to bwyard/axe-core
that referenced
this pull request
May 21, 2026
…alidCustomElementName isShadowRoot was using an ASCII-only regex to identify custom elements, rejecting valid names containing Unicode characters permitted by the HTML spec (e.g. café-menu, math-π) and not excluding the reserved names defined in the custom element name spec. Delegates the check to the isValidCustomElementName util introduced in dequelabs#5097, which implements the full spec-compliant validation. The reservedNames list and custom regex are removed from this file. Tests added for reserved name rejection and Unicode name acceptance. Closes dequelabs#5030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized that I needed this for #5041 as when trying to create the external script and having
get-element-internalsuseisHTMLElementwould result in the external file having all the the different standards objects as well as a ton of unnecessary utils functions. Thus I needed a way to determine if the element is a custom element to short circuit the lookup inget-element-internalswithout relying onisHTMLElement. This implements what we discussed in #5059 into it's own function so it can be used in both places.