Skip to content

feat(new-rule): check that aria-tab have an accessible name - #5001

Merged
chutchins25 merged 11 commits into
developfrom
4842-aria-tab-name
Feb 16, 2026
Merged

feat(new-rule): check that aria-tab have an accessible name#5001
chutchins25 merged 11 commits into
developfrom
4842-aria-tab-name

Conversation

@chutchins25

Copy link
Copy Markdown
Contributor

Added a new rule to check that aria-tab nodes have an accessible name.

Closes: #4842

@chutchins25
chutchins25 requested a review from a team as a code owner January 30, 2026 13:52
Copilot AI review requested due to automatic review settings January 30, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new accessibility rule aria-tab-name to ensure that elements with role="tab" have an accessible name, addressing issue #4842.

Changes:

  • Created the aria-tab-name rule definition that checks for accessible names via visible text, aria-label, aria-labelledby, or title attributes
  • Added comprehensive test coverage for both virtual and integration rule scenarios
  • Updated documentation and localization templates

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/rules/aria-tab-name.json Defines the new rule configuration with selector, checks, and metadata
test/integration/virtual-rules/aria-tab-name.js Adds virtual rule tests covering pass, incomplete, and failure scenarios
test/integration/rules/aria-tab-name/aria-tab-name.json Defines expected test outcomes for integration tests
test/integration/rules/aria-tab-name/aria-tab-name.html Provides HTML test cases for passing and failing scenarios
locales/_template.json Adds localization strings for the new rule
doc/rule-descriptions.md Documents the new rule in the rules reference table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/integration/rules/aria-tab-name/aria-tab-name.html
@chutchins25

Copy link
Copy Markdown
Contributor Author

Looking into why tests are failing in Chrome and Firefox but pass when running with the default npm run test:unit command on local

@chutchins25

Copy link
Copy Markdown
Contributor Author

Fixed. This PR is ready for review once again.

straker
straker previously approved these changes Feb 10, 2026

@straker straker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @WilcoFiers should double check the rule metadata

Comment thread lib/rules/aria-tab-name.json Outdated
Comment thread test/integration/rules/aria-tab-name/aria-tab-name.html Outdated

@WilcoFiers WilcoFiers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chutchins25!

@chutchins25
chutchins25 merged commit 0d4e4e7 into develop Feb 16, 2026
23 checks passed
@chutchins25
chutchins25 deleted the 4842-aria-tab-name branch February 16, 2026 14:49
WilcoFiers added a commit that referenced this pull request Jun 1, 2026
##
[4.12.0](v4.11.4...v4.12.0)
(2026-06-01)

### Features

- add gather-internals.js external script
([#5099](#5099))
([c61d58b](c61d58b)),
closes [#5080](#5080)
- **aria-allowed/prohibited-attr, aria-required-parent/children:**
partially support element internals role
([#5080](#5080))
([417b48a](417b48a)),
closes [#5039](#5039)
[#4259](#4259)
- **axe.externalAPIs:** add public api for setting elementInternal data
([#5105](#5105))
([63bab8f](63bab8f))
- **core:** expose normalizeRunOptions
([#4998](#4998))
([b8e6a59](b8e6a59))
- expose axe.resetLocale() to restore the default locale
([#5108](#5108))
([c2b5292](c2b5292)),
closes [#5107](#5107)
- **getRules:** include rule enabled state in returned objects
([#5118](#5118))
([75bf772](75bf772)),
closes [#5116](#5116)
- **list,listitem:** support element internals role
([#5119](#5119))
([7d9d696](7d9d696))
- **new-rule:** check that aria-tab have an accessible name
([#5001](#5001))
([0d4e4e7](0d4e4e7)),
closes [#4842](#4842)
- **rules:** deprecate landmark-complementary-is-top-level rules
([#4992](#4992))
([9e09139](9e09139)),
closes [#4950](#4950)
- **utils:** add `getElementInternals` function
([#5077](#5077))
([1c15f82](1c15f82))

### Bug Fixes

- **aria-allowed-attr:** restrict br and wbr elements to aria-hidden
only ([#4974](#4974))
([c6245e7](c6245e7))
- **aria-conditional-attr:** add support for radio
([#5100](#5100))
([8223c98](8223c98))
- **aria-valid-attr-value:** handle multiple aria-errormessage IDs
([#4973](#4973))
([0489e30](0489e30))
- **aria:** prevent getOwnedVirtual from returning duplicate nodes
([#4987](#4987))
([48ca955](48ca955)),
closes [#4840](#4840)
- **commons/text:** exclude natively hidden elements from
aria-labelledby accessible name
([#5076](#5076))
([ea7202c](ea7202c)),
closes [#4704](#4704)
- **DqElement:** avoid calling constructors with cloneNode
([#5013](#5013))
([0281fa1](0281fa1))
- **existing-rule:** aria-busy now shows an error message for a use with
unallowed children
([#5017](#5017))
([2067b87](2067b87))
- **helpUrl:** ensure axe.configure always updates the help URLs
([#5114](#5114))
([c4f60ff](c4f60ff))
- **label-content-name-mismatch:** match visible text with aria-label
and exclude invisible text
([#5096](#5096))
([3a012a1](3a012a1))
- **locale:** ensure all subtags are correctly set
([#5112](#5112))
([13005ed](13005ed))
- **scrollable-region-focusable:** clarify the issue is in safari
([#4995](#4995))
([4ec5211](4ec5211)),
closes
[WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870)
[WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290)
- **scrollable-region-focusable:** do not fail scroll areas when all
content is visible without scrolling
([#4993](#4993))
([838707a](838707a))
- **target-size:** determine offset using clientRects if target is
display:inline
([#5012](#5012))
([a4b8091](a4b8091))
- **target-size:** ignore position: fixed elements that are offscreen
when page is scrolled
([#5066](#5066))
([1229a6e](1229a6e)),
closes [#5065](#5065)
- **target-size:** ignore widgets that are inline with other inline
elements ([#5000](#5000))
([a8dd81b](a8dd81b))
- **utils/getAncestry:** escape node name
([#5079](#5079))
([d1fabaa](d1fabaa)),
closes [#5078](#5078)
- **utils:** Add null check to parseCrossOriginStylesheet, closes
[#5074](#5074)
([#5075](#5075))
([f12ef32](f12ef32))
- **utils:** update isShadowRoot to use spec-compliant custom element
regex ([#5059](#5059))
([edc6ce2](edc6ce2)),
closes [#5030](#5030)

This PR was opened by a robot 🤖 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail tabs without an accessible name

4 participants