fix(scrollable-region-focusable): clarify the issue is in safari - #4995
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request clarifies that the scrollable-region-focusable rule is specifically a Safari browser issue by updating the rule's description metadata. This addresses confusion from users reporting false positives, as they were not aware this accessibility issue is Safari-specific. The PR description notes this is unusual for axe-core to call out a specific browser, but the overhead of maintaining this specificity is justified given the user confusion it resolves.
Changes:
- Updated the description field in the rule's JSON metadata to explicitly mention Safari
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "metadata": { | ||
| "description": "Ensure elements that have scrollable content are accessible by keyboard", | ||
| "description": "Ensure elements that have scrollable content are accessible by keyboard in Safari", | ||
| "help": "Scrollable region must have keyboard access" |
There was a problem hiding this comment.
The "help" text should also mention Safari for consistency with the updated "description" field. Users typically see the help text in accessibility testing tools, so it's important to clarify there as well that this is a Safari-specific issue. Consider updating to: "Scrollable region must have keyboard access in Safari"
| "help": "Scrollable region must have keyboard access" | |
| "help": "Scrollable region must have keyboard access in Safari" |
straker
left a comment
There was a problem hiding this comment.
We should make a similar change to the help docs.
Part of #4830 Doesn't close the issue, but people keep reporting this as a false positive because we don't make it clear this is a Safari-only issue. Axe-core explicitly calling out a browser or screen reader is unusual, but I think the problem not doing this creates here is bigger than the overhead it would be for us to keep an eye on this and pull this out. If Safari ever addresses this the rule can be deprecated completely. See related Webkit bugs: - [WebKit#190870: Make scrollable element focusable](https://bugs.webkit.org/show_bug.cgi?id=190870) - [WebKit#277290: AX: Scrolling containers inoperable with keyboard](https://bugs.webkit.org/show_bug.cgi?id=277290)
Part of #4830 Doesn't close the issue, but people keep reporting this as a false positive because we don't make it clear this is a Safari-only issue. Axe-core explicitly calling out a browser or screen reader is unusual, but I think the problem not doing this creates here is bigger than the overhead it would be for us to keep an eye on this and pull this out. If Safari ever addresses this the rule can be deprecated completely. See related Webkit bugs: - [WebKit#190870: Make scrollable element focusable](https://bugs.webkit.org/show_bug.cgi?id=190870) - [WebKit#277290: AX: Scrolling containers inoperable with keyboard](https://bugs.webkit.org/show_bug.cgi?id=277290)
### [4.11.2](v4.11.1...v4.11.2) (2026-03-30) ### Bug Fixes - **aria-valid-attr-value:** handle multiple aria-errormessage IDs ([#4973](#4973)) ([9322148](9322148)) - **aria:** prevent getOwnedVirtual from returning duplicate nodes ([#4987](#4987)) ([99d1e77](99d1e77)), closes [#4840](#4840) - **DqElement:** avoid calling constructors with cloneNode ([#5013](#5013)) ([88bc57f](88bc57f)) - **existing-rule:** aria-busy now shows an error message for a use with unallowed children ([#5017](#5017)) ([dded75a](dded75a)) - **scrollable-region-focusable:** clarify the issue is in safari ([#4995](#4995)) ([2567afd](2567afd)), closes [WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870) [WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290) - **scrollable-region-focusable:** do not fail scroll areas when all content is visible without scrolling ([#4993](#4993)) ([240f8b5](240f8b5)) - **target-size:** determine offset using clientRects if target is display:inline ([#5012](#5012)) ([69d81c1](69d81c1)) - **target-size:** ignore widgets that are inline with other inline elements ([#5000](#5000)) ([cf8a3c0](cf8a3c0))
## [4.12.0](v4.11.4...v4.12.0) (2026-06-01) ### Features - add gather-internals.js external script ([#5099](#5099)) ([c61d58b](c61d58b)), closes [#5080](#5080) - **aria-allowed/prohibited-attr, aria-required-parent/children:** partially support element internals role ([#5080](#5080)) ([417b48a](417b48a)), closes [#5039](#5039) [#4259](#4259) - **axe.externalAPIs:** add public api for setting elementInternal data ([#5105](#5105)) ([63bab8f](63bab8f)) - **core:** expose normalizeRunOptions ([#4998](#4998)) ([b8e6a59](b8e6a59)) - expose axe.resetLocale() to restore the default locale ([#5108](#5108)) ([c2b5292](c2b5292)), closes [#5107](#5107) - **getRules:** include rule enabled state in returned objects ([#5118](#5118)) ([75bf772](75bf772)), closes [#5116](#5116) - **list,listitem:** support element internals role ([#5119](#5119)) ([7d9d696](7d9d696)) - **new-rule:** check that aria-tab have an accessible name ([#5001](#5001)) ([0d4e4e7](0d4e4e7)), closes [#4842](#4842) - **rules:** deprecate landmark-complementary-is-top-level rules ([#4992](#4992)) ([9e09139](9e09139)), closes [#4950](#4950) - **utils:** add `getElementInternals` function ([#5077](#5077)) ([1c15f82](1c15f82)) ### Bug Fixes - **aria-allowed-attr:** restrict br and wbr elements to aria-hidden only ([#4974](#4974)) ([c6245e7](c6245e7)) - **aria-conditional-attr:** add support for radio ([#5100](#5100)) ([8223c98](8223c98)) - **aria-valid-attr-value:** handle multiple aria-errormessage IDs ([#4973](#4973)) ([0489e30](0489e30)) - **aria:** prevent getOwnedVirtual from returning duplicate nodes ([#4987](#4987)) ([48ca955](48ca955)), closes [#4840](#4840) - **commons/text:** exclude natively hidden elements from aria-labelledby accessible name ([#5076](#5076)) ([ea7202c](ea7202c)), closes [#4704](#4704) - **DqElement:** avoid calling constructors with cloneNode ([#5013](#5013)) ([0281fa1](0281fa1)) - **existing-rule:** aria-busy now shows an error message for a use with unallowed children ([#5017](#5017)) ([2067b87](2067b87)) - **helpUrl:** ensure axe.configure always updates the help URLs ([#5114](#5114)) ([c4f60ff](c4f60ff)) - **label-content-name-mismatch:** match visible text with aria-label and exclude invisible text ([#5096](#5096)) ([3a012a1](3a012a1)) - **locale:** ensure all subtags are correctly set ([#5112](#5112)) ([13005ed](13005ed)) - **scrollable-region-focusable:** clarify the issue is in safari ([#4995](#4995)) ([4ec5211](4ec5211)), closes [WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870) [WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290) - **scrollable-region-focusable:** do not fail scroll areas when all content is visible without scrolling ([#4993](#4993)) ([838707a](838707a)) - **target-size:** determine offset using clientRects if target is display:inline ([#5012](#5012)) ([a4b8091](a4b8091)) - **target-size:** ignore position: fixed elements that are offscreen when page is scrolled ([#5066](#5066)) ([1229a6e](1229a6e)), closes [#5065](#5065) - **target-size:** ignore widgets that are inline with other inline elements ([#5000](#5000)) ([a8dd81b](a8dd81b)) - **utils/getAncestry:** escape node name ([#5079](#5079)) ([d1fabaa](d1fabaa)), closes [#5078](#5078) - **utils:** Add null check to parseCrossOriginStylesheet, closes [#5074](#5074) ([#5075](#5075)) ([f12ef32](f12ef32)) - **utils:** update isShadowRoot to use spec-compliant custom element regex ([#5059](#5059)) ([edc6ce2](edc6ce2)), closes [#5030](#5030) This PR was opened by a robot 🤖 🎉
Part of #4830
Doesn't close the issue, but people keep reporting this as a false positive because we don't make it clear this is a Safari-only issue. Axe-core explicitly calling out a browser or screen reader is unusual, but I think the problem not doing this creates here is bigger than the overhead it would be for us to keep an eye on this and pull this out. If Safari ever addresses this the rule can be deprecated completely.
See related Webkit bugs: