fix(valid-lang): update valid-langs for newer language codes - #4966
Merged
Conversation
WilcoFiers
previously requested changes
Dec 17, 2025
WilcoFiers
left a comment
WilcoFiers
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test for lang="isv"? That was the original case, I'd like proof that this passes.
Member
|
Drafting until Steven is back from vacation. |
Garbee
marked this pull request as draft
December 22, 2025 14:15
Member
It seems to be there: https://github.com/dequelabs/axe-core/pull/4966/changes#diff-fb86b1ebad45c23a42149f319e8708715f4b305e1d2f454c269e24b6a7f1a3beR7 |
pwsmaster
approved these changes
Dec 24, 2025
straker
marked this pull request as ready for review
January 5, 2026 16:44
WilcoFiers
approved these changes
Jan 6, 2026
Garbee
approved these changes
Jan 6, 2026
Garbee
left a comment
Garbee
left a comment
Member
There was a problem hiding this comment.
LGTM. Nice comment in this valid-langs to detail what is going on.
WilcoFiers
added a commit
that referenced
this pull request
Jan 6, 2026
### [4.11.1](v4.11.0...v4.11.1) (2026-01-06) ### Bug Fixes - allow shadow roots in axe.run contexts ([#4952](#4952)) ([d4aee16](d4aee16)), closes [#4941](#4941) - color contrast fails for oklch and oklab with none ([#4959](#4959)) ([8f249fd](8f249fd)) - **color-contrast:** do not incomplete on textarea ([#4968](#4968)) ([d271788](d271788)), closes [#4947](#4947) - **commons/color:** Match browser behavior for out-of-gamut oklch colors ([#4908](#4908)) ([5036be8](5036be8)) - don't runs rules that select `html` on nested `html` elements ([#4969](#4969)) ([1e9a5c3](1e9a5c3)) - replaced luminance threshold constant 0.03928 with 0.04045 ([#4934](#4934)) ([316967d](316967d)), closes [#4933](#4933) - **rgaa:** adjust mapping of aria-hidden-\* and valid-lang ([#4935](#4935)) ([77571f2](77571f2)) - **valid-lang:** update valid-langs for newer language codes ([#4966](#4966)) ([c3f5446](c3f5446)), closes [#4963](#4963) This PR was opened by a robot 🤖 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just ran the script in the comment of the file on the latest version of the page to update the data.
Note: the removal of
eslint-disable-next-lineseems to happen on commit and wasn't something I did.Closes: #4963