Skip to content

test(performance-timer): reduce flakiness of tests involving actual sleeps (round 2) - #4896

Merged
dbjorge merged 1 commit into
developfrom
flaky-test-2
Sep 30, 2025
Merged

test(performance-timer): reduce flakiness of tests involving actual sleeps (round 2)#4896
dbjorge merged 1 commit into
developfrom
flaky-test-2

Conversation

@dbjorge

@dbjorge dbjorge commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

@dbjorge
dbjorge requested a review from a team as a code owner September 30, 2025 16:53
Copilot AI review requested due to automatic review settings September 30, 2025 16:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses flakiness in performance timer tests by adding tolerance for browser sleep timing inconsistencies. The tests were failing when actual sleep durations were slightly less than expected due to browser main thread synchronization behavior.

  • Adds a tolerance constant for animation frame timing variations
  • Updates all assertions that check for minimum sleep duration to account for timing variations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dbjorge
dbjorge merged commit 670be64 into develop Sep 30, 2025
23 checks passed
@dbjorge
dbjorge deleted the flaky-test-2 branch September 30, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants