fix(frame-title-unique): Make frame-title-unique reviewOnly and WCAG412 #3610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rule references: #3487
WilcoFiers
previously requested changes
Aug 17, 2022
WilcoFiers
previously requested changes
Aug 23, 2022
Contributor
WilcoFiers
left a comment
WilcoFiers
left a comment
There was a problem hiding this comment.
Good catch on the Rule class change. This turned out more complicated than I expected it would be.
dbowling
dismissed
WilcoFiers’s stale review
after callback has been given own describe, and any/all/none cases each have tests
WilcoFiers
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aze-core's
frame-title-uniquerule is currently inconsistent with ACT Rules because it is far too strict.This makes the rule partially consistent with the Iframe elements with identical accessible names have equivalent purpose ACT rule.
wcag412andwcag2abest-practice"reviewOnFail": truereferences: #3487