Skip to content

feat(aria-allowed-attr): add ARIA 1.2 prohibited attrs check - #2764

Merged
straker merged 2 commits into
developfrom
prohibited-attrs
Jan 19, 2021
Merged

feat(aria-allowed-attr): add ARIA 1.2 prohibited attrs check#2764
straker merged 2 commits into
developfrom
prohibited-attrs

Conversation

@straker

@straker straker commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Aira 1.2 added Prohibited States and Props which prevent certain ARIA attributes from being allowed on certain roles. Implementing this as a prerequisite of #1575

Related discussions:

In another PR, we can make it so in implicitRole any html element without a role returns generic, which prohibits aria-label and aria-labelledby, thus fixing #1575.

From Scott O'Hara on asking about HTML elements with no role mapping:

no mapping = generic
generic doesn't allow naming

@straker
straker requested a review from a team as a code owner January 18, 2021 22:31
@WilcoFiers WilcoFiers changed the title chore: add prohibited attrs to aria-allowed-attr feat(aria-allowed-attr): add ARIA 1.2 prohibited attrs check Jan 19, 2021
@straker
straker merged commit 4a77e88 into develop Jan 19, 2021
@straker
straker deleted the prohibited-attrs branch January 19, 2021 16:02
@veselints

Copy link
Copy Markdown

@straker why the latest official release of axe-core contains a rule that is part of the WAI-ARIA 1.2 recommendation? That is still a candidate. I believe the official releases should be based only on official specs and recommendations. I know that the 1.2 rec is an improvement of the 1.1 and soon or later the above should be part of axe-core, but the rules from a candidate should go to a beta/dev channel of the package and not in the official release.

@straker

straker commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

@veselints axe-core contains best-practice rules and checks that aren't part of the ARIA spec (such as aria-dialog-name), as well as rules that inform the user of problems they might not be aware of (such as this one and presentation-role-conflict). We test current screen reader support and will add new rules and future ARIA spec concepts based on what screen readers do today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants