fix: support kyverno chart changes (but keep kyverno version)#92
Merged
thesuperzapper merged 1 commit intoFeb 5, 2024
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This was referenced Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an incompatible change introduced in newer versions of the Kyverno chart, mainly that
kyverno.cleanupController.rbac.clusterRole.extraResources[0].verbsnow needs to be set.It also cleans up two case where we set
mutateExistingOnPolicyUpdate: falsedespite that being the default, and replaced instances of{{ request.namespace }}with{{ request.object.metadata.namespace }}because these seem to be problematic in Kyverno 1.11.However, the Kyverno version remains as
1.10.0, and we have left the chart version as3.0.1WARNING: We still can NOT update to any version of Kyverno from
1.10.1to1.11.4, as all have problems that make them incompatible with deployKF:targetsfail to apply for trigger resources with names > 63 characters kyverno/kyverno#9134targetsset) do not clone kyverno/kyverno#9571