fix: annotate cloned imagePullSecrets to be ignored by ArgoCD#90
Merged
Conversation
Signed-off-by: Denis Khachyan <[email protected]>
Member
|
@dkhachyan I assume this is required in your use-case because your image-pull-secret source is part of another ArgoCD application (so have the ArgoCD labels/annotations)? |
Contributor
Author
|
Yes exactly |
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
changed the title
thesuperzapper
approved these changes
Feb 5, 2024
thesuperzapper
left a comment
thesuperzapper
left a comment
Member
There was a problem hiding this comment.
@dkhachyan there was a slight error, but I pushed commit 260bbce to fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so that secrets cloned by the
deploykf_dependencies.kyverno.clusterPolicies.imagePullSecretspolicy are annotated withargocd.argoproj.io/compare-options: IgnoreExtraneousandargocd.argoproj.io/sync-options: Prune=falseto prevent ArgoCD pruning them or showing source secret's app as our of sync (if it comes from one).