Skip to content

feat: add pod-labels value for cert-manager controller#88

Merged
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:feat-add-pod-labels-value-cert-manager
Jan 28, 2024
Merged

feat: add pod-labels value for cert-manager controller#88
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:feat-add-pod-labels-value-cert-manager

Conversation

@thesuperzapper

@thesuperzapper thesuperzapper commented Jan 28, 2024

Copy link
Copy Markdown
Member

closes: #59

This PR adds the deploykf_dependencies.cert_manager.controller.podLabels value, which allows users to set labels on the cert-manager controller Pods. This new value is required to make use of Azure AD Workload Identity in cert-manager.

For example, you can now use the following values:

deploykf_dependencies:
  cert_manager:
    controller:
      podLabels:
        azure.workload.identity/use: "true"

      serviceAccount:
        annotations:
          azure.workload.identity/client-id: "00000000-0000-0000-0000-000000000000"

          ## only needed if want a non-default AZURE_TENANT_ID
          #azure.workload.identity/tenant-id: "00000000-0000-0000-0000-000000000000"

@thesuperzapper thesuperzapper added this to the v0.1.4 milestone Jan 28, 2024
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into an upcoming release label Jan 28, 2024
@thesuperzapper
thesuperzapper merged commit 5b1a52f into deployKF:main Jan 28, 2024
@thesuperzapper
thesuperzapper deleted the feat-add-pod-labels-value-cert-manager branch January 28, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog/feature status/ready-to-merge status - this will be merged into an upcoming release

Projects

None yet

Milestone

v0.1.4

Development

Successfully merging this pull request may close these issues.

add values for cert-manager to use Azure AD Workload Identity

1 participant

@thesuperzapper