improve: use __Secure- cookie prefix and remove domains config#87
Merged
thesuperzapper merged 1 commit intoJan 28, 2024
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepends
__Secure-to our token cookie name whendeploykf_core.deploykf_istio_gateway.gateway.tls.clientsUseHttpsis true (indicating that users are connecting to deplopyKF over HTTPS), as browsers require HTTPS for theSecureattribute to be set, which itself is required to use the__Secure-prefix.https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#__host-
We also set
cookie_domainsto an empty list in our oauth2-proxy configs, as previously oauth2-proxy was spamming[WARNING] ...logs because it could not match the cookie domain to requests (when using non-standard ports). This change should have no effect, as deployKF currently always uses the samedeploykf_core.deploykf_istio_gateway.gateway.hostnamefor all services so there is no reason to "force" a specific top-level one.