Skip to content

feat: allow custom external service ports#82

Merged
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:feat-allow-custom-external-service-ports
Jan 27, 2024
Merged

feat: allow custom external service ports#82
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:feat-allow-custom-external-service-ports

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

Previously we assumed the internal (on the istio gateway) and external (on the user-facing service/ingress) ports were always the same.

This PR introduces deploykf_core.deploykf_istio_gateway.gatewayService.ports.http and deploykf_core.deploykf_istio_gateway.gatewayService.ports.https which can be used to either:

  1. Change the ports which the service for the embedded istio gateway listens on:
    • (to potentially make them different from the internal gateway ports, which might help users who want to use the same istio gateway deployment for more than just deployKF)
  2. Inform deployKF about which ports are actually seen by end-users:
    • (for users who are bringing their own gateway service, so that deployKF will correctly generate user-facing links with the correct port)

By default, both new deploykf_core.deploykf_istio_gateway.gatewayService.ports values are ~ (null), and the correspondingdeploykf_core.deploykf_istio_gateway.gateway.ports value is used (which is backward-compatible with the current behavior).

@thesuperzapper thesuperzapper added this to the v0.1.4 milestone Jan 25, 2024
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into an upcoming release label Jan 27, 2024
@thesuperzapper
thesuperzapper force-pushed the feat-allow-custom-external-service-ports branch from a6bf607 to b90dade Compare January 27, 2024 22:30
@thesuperzapper
thesuperzapper force-pushed the feat-allow-custom-external-service-ports branch from b90dade to 2f5de48 Compare January 27, 2024 22:45
@thesuperzapper
thesuperzapper merged commit f55f1bd into deployKF:main Jan 27, 2024
@thesuperzapper
thesuperzapper deleted the feat-allow-custom-external-service-ports branch January 27, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature status/ready-to-merge status - this will be merged into an upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant