feat: allow custom external service ports#82
Merged
thesuperzapper merged 1 commit intoJan 27, 2024
Merged
Conversation
thesuperzapper
force-pushed
the
feat-allow-custom-external-service-ports
branch
from
January 27, 2024 22:30
a6bf607 to
b90dade
Compare
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
feat-allow-custom-external-service-ports
branch
from
January 27, 2024 22:45
b90dade to
2f5de48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we assumed the internal (on the istio gateway) and external (on the user-facing service/ingress) ports were always the same.
This PR introduces
deploykf_core.deploykf_istio_gateway.gatewayService.ports.httpanddeploykf_core.deploykf_istio_gateway.gatewayService.ports.httpswhich can be used to either:By default, both new
deploykf_core.deploykf_istio_gateway.gatewayService.portsvalues are~(null), and the correspondingdeploykf_core.deploykf_istio_gateway.gateway.portsvalue is used (which is backward-compatible with the current behavior).