fix: proxy protocol envoyfilter for istio gateway#80
Merged
thesuperzapper merged 2 commits intoJan 27, 2024
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
added
the
status/ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the vast majority of users do not need to enable
deploykf_core.deploykf_istio_gateway.gateway.enableProxyProtocol, our previous implementation was not working properly in newer versions of Istio. This PR updates the method of enabling "proxy protocol" on the gateway to the one described on this page of Istio's docs.Note, setting
deploykf_core.deploykf_istio_gateway.gateway.enableProxyProtocoltotruenow requires Istio 1.17+. as this was the version that introducedapplyTo: LISTENER_FILTERin the EnvoyFilter spec.