fix: using AWS IRSA with Kubeflow Pipelines#79
Merged
thesuperzapper merged 1 commit intoJan 27, 2024
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #75
IRSA bucket authentication did not work properly in Kubeflow Pipelines because there were default values for access-key environment variables like
OBJECTSTORECONFIG_ACCESSKEY,MINIO_ACCESS_KEY, andAWS_ACCESS_KEY_IDwhich were preventing the AWS credential provider from using the Pod's IRSA authentication.This PR simply explicitly sets all the access key env-vars to
""whenkubeflow_tools.pipelines.objectStore.auth.fromEnvisfalse, so they are ignored and IRSA auth is attempted.NOTE: this must be merged AFTER: #54
PS: thanks to @flaccid for testing this fix.