Skip to content

feat: disable default plugins and resource-quotas in specific profiles#67

Merged
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:allow-override-default-profile-plugins-and-quotas
Jan 27, 2024
Merged

feat: disable default plugins and resource-quotas in specific profiles#67
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:allow-override-default-profile-plugins-and-quotas

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

The PR allows you to disable the default plugins or resourceQuotaSpec for a specific profile by setting them to [] and {} respectively in that profile definition. Previously, these were interpreted as "false" so would have been assigned the defaults, even if explicitly set as empty.

For example, the following will now behave as expected:

deploykf_core:
  deploykf_profiles_generator:
    
    profileDefaults:
      plugins:
        - kind: AwsIamForServiceAccount
          spec:
            awsIamRole: arn:aws:iam::000000000000:role/MY_ROLE_NAME
            AnnotateOnly: true
            
      resourceQuotaSpec:
        hard:
          pods: 100

    profiles:
      - name: profile-with-defaults
        members: ...
        
      - name: profile-with-no-plugins
        plugins: []
        members: ...

      - name: profile-with-no-limits
        resourceQuotaSpec: {}
        members: ...

@thesuperzapper thesuperzapper added this to the v0.1.4 milestone Dec 13, 2023
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into an upcoming release label Dec 13, 2023
@thesuperzapper
thesuperzapper merged commit cf1314e into deployKF:main Jan 27, 2024
@thesuperzapper
thesuperzapper deleted the allow-override-default-profile-plugins-and-quotas branch January 27, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature status/ready-to-merge status - this will be merged into an upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant