fix: don't mount trust bundles with own cert-manager#46
Merged
thesuperzapper merged 1 commit intoOct 31, 2023
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where we followed the self-signed gateway code path when the user brought their own
cert-managerdeployment, unless they explicitly did something like disablingdeploykf_dependencies.cert_manager.clusterIssuer.enabled.As there is no reasonable case where someone would want to bring their own
cert-managerbut use a self-signed certificate, we now assume that the gateway is NOT using a self-signed certificate, when the user brings their owncert-manager.This primarily fixes an issue where Pods would fail to start because we would try and mount the
trust-managerBundle ConfigMaps as volumes on Pods, but the Bundle would not exist when the user disables the embeddedcert-manager.