feat: browser-based KFP SDK auth#45
Merged
thesuperzapper merged 1 commit intoOct 31, 2023
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for browser-based authentication (also known as "out-of-band" OIDC login) with the Kubeflow Pipelines SDK.
This is achieved by making the following changes:
kubeflow-pipelines-sdkurn:ietf:wg:oauth:2.0:oobredirect URI (prompts the user to copy a code)We have also added another layer of security where we can restrict HTTP paths depending on the JWT bearer
aud.For example, JWT tokens generated under the new
kubeflow-pipelines-sdkOIDC client, can ONLY access the/pipelinesAPI path, but NOT the deployKF dashboard or any other paths.