fix: ensure namespaces are never deleted or pruned#31
Merged
thesuperzapper merged 1 commit intoSep 21, 2023
Conversation
thesuperzapper
force-pushed
the
never-prune-namespaces
branch
from
September 21, 2023 19:54
06da687 to
b3764a3
Compare
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
never-prune-namespaces
branch
from
September 21, 2023 20:21
b3764a3 to
a6436bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because users may store other things in the deployKF namespaces (especially the ones for dependencies), we should never automatically delete them.
This PR ensures that ArgoCD will never "prune" (on sync) or "delete" (on app uninstall) a namespace.
WARNING: this does NOT apply to the profile namespaces, which the profile controller will delete as soon as their
Profilecluster-resource is removed.