fix: create separate namespaces app, if destination is remote#30
Merged
thesuperzapper merged 1 commit intoSep 21, 2023
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
namespaces-app-for-remote
branch
from
September 21, 2023 19:02
4828aaa to
ddc438a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that prevented deployments from "management" ArgoCD clusters into remote "destination" clusters.
The issue was that the
deploykf-app-of-appArgoCD application contained the namespaces, which would mean that they were deployed onto the "management" cluster, rather than the "destination".To ensure backward compatibility, the
deploykf-namespacesapp will only appear if theargocd.destinationis NOTin-clusterorhttps://kubernetes.default.svc, otherwise they remain in thedeploykf-app-of-appapp.