fix: set kyverno webhook failure policy to ignore (fix uninstall deadlock)#26
Merged
thesuperzapper merged 1 commit intoSep 21, 2023
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #24
Currently, Kyverno
1.10will not clean up itsValidatingWebhookConfigurationsandMutatingWebhookConfigurationswhen uninstalled, which will always result in the cluster being deadlocked. This is because Kyverno's webhooks intercept most Kubernetes API requests for validation, and if Kyverno no longer exists, it will fail.This PR tells Kyverno to "fail open" on the resource webook, to prevent this issue.
We can revert this change once kyverno/kyverno#8390 is resolved.
Note, that the webhooks will still be left on uninstall with this change, they won't deadlock the cluster.
To remove the webhooks fully, follow Kyverno's guide, and run:
Also, I have included changes necessary to update to newer versions of Kyvernos's helm chart, but currently, we can't update past Kyverno
1.10.0as Kyverno broke support for replicating secrets with longer than 63 characters in1.10.1.Note, chart
3.0.1(our current default) includes Kyverno1.10.0.