Skip to content

feat: allow a single ArgoCD to manage deployKF across multiple clusters#17

Merged
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:argocd-app-name-prefix
Aug 8, 2023
Merged

feat: allow a single ArgoCD to manage deployKF across multiple clusters#17
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:argocd-app-name-prefix

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

This PR enables a single instance of ArgoCD to manage deployKF across multiple clusters.

For example, it is common to have an ArgoCD "management cluster" which deploys applications to other Kubernetes clusters, so those clusters don't need to have ArgoCD installed separately.

This is achieved by adding the following values:

  • argocd.appNamePrefix:
    • Previously you could only apply one instance of the deployKF ArgoCD Applications to a cluster (as the names would overlap), this value lets you prefix the application names.
  • argocd.destination.name:
    • Allows setting the spec.destination.name of the Application resources, in addition to our already existing argocd.destination.server value for setting spec.destination.server.

@thesuperzapper thesuperzapper changed the title feat: allow a single argocd to manage deployKF across multiple clusters feat: allow a single ArgoCD to manage deployKF across multiple clusters Aug 8, 2023
@thesuperzapper thesuperzapper added this to the v0.1.1 milestone Aug 8, 2023
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into an upcoming release label Aug 8, 2023
@thesuperzapper
thesuperzapper force-pushed the argocd-app-name-prefix branch from 24fff53 to 98f2b5e Compare August 8, 2023 22:10
@thesuperzapper
thesuperzapper merged commit 07870c2 into deployKF:main Aug 8, 2023
@thesuperzapper
thesuperzapper deleted the argocd-app-name-prefix branch August 8, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature status/ready-to-merge status - this will be merged into an upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant