feat: allow a single ArgoCD to manage deployKF across multiple clusters#17
Merged
thesuperzapper merged 1 commit intoAug 8, 2023
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
argocd-app-name-prefix
branch
from
August 8, 2023 22:10
24fff53 to
98f2b5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables a single instance of ArgoCD to manage deployKF across multiple clusters.
For example, it is common to have an ArgoCD "management cluster" which deploys applications to other Kubernetes clusters, so those clusters don't need to have ArgoCD installed separately.
This is achieved by adding the following values:
argocd.appNamePrefix:argocd.destination.name:spec.destination.nameof the Application resources, in addition to our already existingargocd.destination.servervalue for settingspec.destination.server.