fix: minio not starting, upstream removed curl#165
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an error introduced by #158 (which was never part of a release).
The issue is that
curlhas been removed from the upstream MinIO images (docker.io/minio/minio). Therefore, in this PR we have moved to the Bitnami ones (docker.io/bitnami/minio), as they have no pull limit on Dockerhub and still contain thecurlbinary.For reference, we need the curl binary to check that dex is up before starting MinIO. If dex is not up before MinIO starts, then it will never try to access the OpenID provider again, and there will be no way to log in.