fix: require pruning in sync script#123
Merged
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
sync_argocd_apps.shscript allowed users to skip pruning while syncing (and this was actually the default behavior if a user did not respond to the prompt for 60 seconds). This was causing many users to accidentally not prune resources, which can break things like authentication (Istio resources), and more.Specifically, the following changes have been made:
ARGOCD_PRUNE_MODEcalledask, which is the new default:ALWAYS pruneorPROMPT for each(which correspond to the other values ofARGOCD_PRUNE_MODE)promptmode ofARGOCD_PRUNE_MODEhas changed:deploykf-profiles-generatoranddeploykf-app-of-appsskipmode ofARGOCD_PRUNE_MODEhas been removed.