Skip to content

fix: require pruning in sync script#123

Merged
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:update-sync-script
Apr 24, 2024
Merged

fix: require pruning in sync script#123
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:update-sync-script

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

Previously, the sync_argocd_apps.sh script allowed users to skip pruning while syncing (and this was actually the default behavior if a user did not respond to the prompt for 60 seconds). This was causing many users to accidentally not prune resources, which can break things like authentication (Istio resources), and more.

Specifically, the following changes have been made:

  • All configs can now be set from exported environment variables (rather than only by updating the script itself)
  • The logs are now more clear.
  • We have added a new ARGOCD_PRUNE_MODE called ask, which is the new default:
    • this mode will ask the user (each time they run the script) to decide if they want to ALWAYS prune or PROMPT for each (which correspond to the other values of ARGOCD_PRUNE_MODE)
  • The behaviour of the prompt mode of ARGOCD_PRUNE_MODE has changed:
    • when an application requires pruning, and they choose not to prune, the sync will fail
    • we now print some tips for specific apps, namely the deploykf-profiles-generator and deploykf-app-of-apps
  • The skip mode of ARGOCD_PRUNE_MODE has been removed.

@thesuperzapper thesuperzapper added this to the v0.1.5 milestone Apr 23, 2024
@thesuperzapper thesuperzapper changed the title fix: require pruning in sync script & other improvements fix: require pruning in sync script Apr 24, 2024
@thesuperzapper
thesuperzapper merged commit ae33917 into deployKF:main Apr 24, 2024
@thesuperzapper
thesuperzapper deleted the update-sync-script branch April 24, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant