feat: allow custom documentation links in dashboard#12
Merged
Conversation
thesuperzapper
requested changes
Jul 13, 2023
thesuperzapper
left a comment
thesuperzapper
left a comment
Member
There was a problem hiding this comment.
@yankcrime you have the honor of being the first external PR!
I am happy to allow users to customize the links, but see my comment.
Similar to links in the sidebar, this commit updates the values files to allow configuring the documentation links section on the dashboard home page. Signed-off-by: Nick Jones <[email protected]>
yankcrime
force-pushed
the
documentation_links
branch
from
July 13, 2023 10:05
8da4f4b to
8d25e25
Compare
thesuperzapper
approved these changes
Jul 21, 2023
thesuperzapper
left a comment
thesuperzapper
left a comment
Member
There was a problem hiding this comment.
@yankcrime looks great, I will merge it closer to the next release, so people don't get confused by seeing it in the main branch.
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to links in the sidebar, this commit updates the values files to allow configuring the documentation links section on the dashboard home page.
Adds the
deploykf_core.deploykf_dashboard.navigation.documentationItemsvalue, which is a list of links.