improve: support argocd.appNamePrefix in argocd sync script#108
Merged
thesuperzapper merged 1 commit intoFeb 20, 2024
Merged
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
sync_argocd_apps.shscript to support theargocd.appNamePrefixvalue being set. We achieve this by introducing a new script config calledARGOCD_APP_NAME_PREFIXwhich must be set to the same value as theargocd.appNamePrefixof the deployKF instance which you want to sync.Before this change, running the script would result in syncing all deployKF clusters managed by the ArgoCD instance, which is probably not what the user wants.
This change also makes it so that if we don't detect the
deploykf-app-of-appsApplication, the sync will immediately fail.