Skip to content

improve: argocd sync script should only wait for app health once#104

Merged
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:improve-sync-script
Feb 14, 2024
Merged

improve: argocd sync script should only wait for app health once#104
thesuperzapper merged 1 commit into
deployKF:mainfrom
thesuperzapper:improve-sync-script

Conversation

@thesuperzapper

Copy link
Copy Markdown
Member

This PR improves the sync_argocd_apps.sh script in the following ways:

  • Only wait for each app to become healthy one time. Previously, we waited once after the sync (for the out-of-sync apps we just synced), and again for all the apps (even the ones which were not synced). Now we only do the second one.
  • Increases the default ARGOCD_PRUNE_PROMPT_SECONDS to 60 seconds
  • Improves the warning about pruning to explain that ArgoCD incorrectly displays resources that have argocd.argoproj.io/sync-options: Prune=false annotation as requiring pruning, when during an actual prune sync, they are not actually pruned:
  • Improves the force-sync feature to also work with namespaced resources:
    • (NOTE: we currently still only use it for ClusterPolicies, which are not namespaced)

@thesuperzapper thesuperzapper changed the title improve: sync script should only wait for app health once improve: argocd sync script should only wait for app health once Feb 14, 2024
@thesuperzapper
thesuperzapper merged commit 01b0aaf into deployKF:main Feb 14, 2024
@thesuperzapper
thesuperzapper deleted the improve-sync-script branch February 14, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant