improve: stop using kyverno to provision kfp profile resources#102
Merged
thesuperzapper merged 2 commits intoFeb 15, 2024
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
deleted the
improve-stop-using-kyverno-for-profile-resource-gen
branch
February 15, 2024 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the generation of Kubeflow Pipelines profile resources from Kyverno to explicitly generating them with deployKF templates in the
kubeflow-tools/pipelinesArgoCD app.This is needed because Kyverno (especially the latest version, 1.11.4) has significant performance problems when generating lots of resources (kyverno/kyverno#9633), and there is no real benefit to us depending on Kyverno for generating these resources, as we know the full list of profiles from the user's values.
This also has the added benefit of moving the Kyverno ClusterPolicy (
clone-profile-bucket-secret-....) which clones and triggers restarts for the profile object-store secret, into the the pipelines app itself. Because the pipeline ArgoCD app is synced AFTER MinIO, when each profile is first created, there should no longer be a case where the source secret does not exist, except when users are bringing their own object-store. (Note, this is more of a problem in Kyverno versions newer than 1.10.0, which only re-check for missing source secrets eachBACKGROUND_SCAN_INTERVAL, which defaults to 1 hour: kyverno/kyverno#9560).WARNING: when upgrading deployKF:
yesto the PRUNE prompts). the first sync will always time out when waiting for the pipeline app to become healthy, just sync again after this.ClusterPolicybefore starting a sync:kubectl delete clusterpolicy "kubeflow-pipelines--generate-profile-resources"