feat: optional sign-in page to stop background request CSRF accumulation#100
Merged
thesuperzapper merged 1 commit intoFeb 7, 2024
Merged
Conversation
… CSRF accumulation) Signed-off-by: Mathew Wicks <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #96
Continuing on from #99, this PR creates a permanent fix to background requests accumulating CSRF cookies upon auth token expiry. Specifically, this PR allows enabling the oauth2-proxy sign-in page, which will require a user to click "sign in" before they are redirected to dex (which triggers a CSRF cookie to be added).
When enabled, this will prevent all but the most determined users from exceeding the header limits (and getting 431 errors), because the only way to cause a CSRF cookie to be added is to manually start a dex auth flow.
However, because this change will break our existing
KFPClientManager()class, we will leave the sign-in page disabled by default in deployKF0.1.X, and only enable it by default in0.2.0.NOTE: cluster admins who are seeing lots of 431 errors can enable it before then by setting the
deploykf_core.deploykf_auth.oauth2Proxy.enableSignInPagevalue totrue: