fix: Gradle plugin breaking on ProjectComponentIdentifiers for multimodule projects#305
Merged
jeremylong merged 2 commits intodependency-check:mainfrom Jan 16, 2023
Conversation
jeremylong
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes jeremylong/DependencyCheck#5306
Description of Change
Adds conversion support for ProjectComponentIdentifiers.
From the limited information available in a ProjectComponentIdentifier I considered the projectPath to be the most usable for generating a packageURL, but I'm open for modifications to what is used for the packageURL (I'm not too familiar with gradle, just enough to be able to code this fix)