Remove legacy NodeAuditAnalyzer dependency on NPM audit v1 API#8428
Closed
marcelstoer wants to merge 1 commit intodependency-check:mainfrom
Closed
Remove legacy NodeAuditAnalyzer dependency on NPM audit v1 API#8428marcelstoer wants to merge 1 commit intodependency-check:mainfrom
marcelstoer wants to merge 1 commit intodependency-check:mainfrom
Conversation
boring-cyborg
Bot
added
core
Collaborator
|
I don’t understand this. You can’t use npm CLI to interact with a yarn project? |
Collaborator
Author
|
🙈 I kept storming forward with my head down on a path that leads nowhere. Hasn't happened in quite a while that I ignored "if you want to be fast, you have to go slow". I'll need to start over. |
Collaborator
|
Well, that might be the right path for NodeAuditAnalyzer for the NPM projects? And we can have a separate conversation in #8423 about whether we should support Yarn v1 at all, so just drop the yarn related changes from here for now? I haven't actually looked at the rest, just confused by the Yarn stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Stop going to https://registry.npmjs.org/-/npm/v1/security/audits and parse the audit locally instead for Yarn classic (v1, non-berry).
Related issues
Fixes #8422
Have test cases been added to cover the new functionality?
yes